Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 2 years ago

Responsive QR-Code Web Page

Sagar Bisht•10
@sgr-web-dev
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)
Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Gabriel•170
    @ctrl-brokencode
    Posted about 2 years ago

    Hello! Congrats on uploading this challenge. I hope you don't discourage now and I hope you continue coding and learning from your mistakes. You will go far! Here are some suggestions I've made for you. Make sure to pay attention!

    • Make sure to have a well indented code for better readability;
    • para-1 should be an heading element (instead of p, use h1);
    • Don't forget to delete p on .para-content p. This will apply to both the paragraph and heading;
    • Make the alt text of the image clearer. Say where the QR Code is taking you;
    • There's no need of having width and height in body. Delete the width and change height: 100vh to min-height: 100vh;
    • On the other hand, the component (main container) should have a max-width in rem, but not a height. Remember that the height in the component will automatically be determined by the content inside;
    • The component should have one padding value. This will centralize your image a bit;
    • Display, flex-direction, justify-content and align-items won't be necessary;
    • QR Code Image should have display: block and width or max-width: 100%. Your image should be centered now because of the width and padding.

    Then make some adjustments on the paragraph content, like margin and padding, and you're done! Overall, your code is simple and easy to read. Again, careful with indentations. I wish you the best of luck!

    Marked as helpful
  • Harry05•50
    @harry05555
    Posted about 2 years ago

    The whole elements should be nested, like

    <div class="card"> <div class="qrcode-bg"> <img> </div> <div> h1orh2 p </div> </div>

    Semantics is wrong main point to the main content. You can put a div in your main yes

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub