Responsive Rating Component with Flexbox

Community feedback

• 

  hamza•390

  @Hamzaouladev

  Posted over 2 years ago

  hello @sianidan, great job finishing this project!

  i have some suggestions that you may find interesting:

  the styling of your component looks great, however it may break if the content inside were to change, the reason is that fixed heights make the components prone to overflowing issues.

  my suggestion is to remove the height from the container, and to manage spacing you can add the gap property to your flex parent: .card { gap: 2rem; }

  i hope you find my suggestions helpful, Happy Hacking

  10

  Marked as helpful
• 

  AC 🍀•360

  @alleycaaat

  Posted over 2 years ago

  Great job on your project! Your code looks great, clean and tidy. The person who already commented has good input, having a set height for .container could be problematic, especially when you think about folks viewing your project on a mobile device. Some of them have small screens :) I like to view my projects in Developer Tools (ctrl+shift+i in Chrome) to see the various screen sizes and how it impacts my design.

  For the submit question, using button type=submit will submit the form data to the server when the user clicks the button (unless there's JS to say otherwise), and type=button doesn't have a default behaviour. In this case, since the data isn't actually going anywhere/being collected, I think you're safe with type=button.

  10