Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 1 year ago

Responsive Recipe page

bem
Bamo-D-Abdallah•320
@Bamo-D-Abdallah
A solution to the Recipe page challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

It was completely horrible, I need to learn the fundamentals of CSS better

What challenges did you encounter, and how did you overcome them?

The most difficult was setting the list bulletpoints and numbers which I couldn't do so I gave up.

Also sizing anything was horrible and the responsive is inconsistent.

What specific areas of your project would you like help with?

Overall review of my weaknesses, why do I think my code is a pile of garbage.

Why it feels like I don't know CSS.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Adhi•240
    @Adhi-S12
    Posted about 1 year ago

    Hey your solution is good, here are a few things that you can change/improve:

    • If you want to make only a certain parts of the text to be bold, you <strong> tag around them. Don't use <b> tag as it is not semantic HTML.
    • Don't set height on image containers, instead use the object-fit: cover or object-fit:contain property on the image element to fit the image inside the container.
    • In the top of the page, you've given an height for the image container, since the image's width is 100%, there is some empty white space in the container. Also you've given a gap property which give some space, And use used margin top on the heading too, this is the reason there is so much space between the image container and the h1 heading.
    • You forgot to use the fonts for preperation-block__header class and a few other elements.

    Other than this, your solution is actually good

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub