Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive result summary for absolute Begineers

#react
Nikita Barnwalβ€’ 40

@nikitabarnawal

Desktop design screenshot for the Results summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Please review the code and feel free to comment down on what I need to improve

Community feedback

Abdul Khalid πŸš€β€’ 72,160

@0xabdulkhalid

Posted

Hello there πŸ‘‹. Congratulations on successfully completing your first challenge! πŸŽ‰

  • I have other recommendations regarding your code that I believe will be of great interest to you.

HTML 🏷️:

  • This solution generates accessibility error reports due to non-semantic markup
  • So fix it by replacing the <div id="root"> with semantic element <main> in your index.html file to improve accessibility and organization of your page.
  • What is meant by landmark elements ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>
  • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

HEADINGS ⚠️:

  • And, This solution generates accessibility error reports due to lack of level-one heading <h1>
  • Every site must want at least one h1 element identifying and describing the main content of the page.
  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
  • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

I hope you find it helpful ! πŸ˜„ Above all, the solution you submitted is great

Happy coding!

0
faizanβ€’ 2,420

@afaiz-space

Posted

hey @nikitabarnawal,

  • change color / 100.
  • why not use heading tags for heading.
  • verticle align icons and heading.
0

Nikita Barnwalβ€’ 40

@nikitabarnawal

Posted

@afaiz-space Hey, thanks for the feedback. I will check into it and update the code. Thanks again

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord