Responsive results component using HTML, CSS and pure JS

Community feedback

• 

  Csaba Hell•220

  @hellcsaba

  Posted 8 months ago

  Hi eMKa18,

  Nice solution! I checked your code and live site, here's my feedback. In appearance the only difference I can see (maybe it's intentional) that the background color of the different skills are too strong. Your code is well-structured and readable which is great. You mention in the tags that you used React for the project but I don't see it in the code. Currently you have everything in the HTML except the data, that you get by a fetch call in the JS file (getData()). Additionally, you could have created a component for the skill and populate the DOM through JavaScript. For example a renderSkills function where you retrieve the summary div and through a for loop you append each skill to that div. Each skill is a component filled with the correct data.

  Overall, your solution is great and what I've mentioned above is a way to make it more reusable.

  Happy coding!

  00

  Marked as helpful