Responsive results summary using CSS grid and Flexbox

Community feedback

• 

  Joachim•840

  @Thewatcher13

  Posted about 2 years ago

  Hi helen,

  Well done, but like your other project, the strong elements isn't a good idea for the same reason. (The element strong is used for give more meaning on an element, not for provide any kind of styling. Screenreaders by example go read your strong elements with more emphasis, and in this case that would be make no sense.)

  You should use an ul, instead of span here (what it would be in a plain text)

  21

  Marked as helpful
• 

  Abdul Khaliq 🚀•72,380

  @0xabdulkhaliq

  Posted about 2 years ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  DECORATIVE SVG'S ♨️:

  • The alt attribute is used to provide alternative text for images in HTML documents. The alt attribute is used by screen readers to describe the image to visually impaired users, which is essential for web accessibility.

  ---

  • Now, when it comes to decorative SVGs, they are used purely for aesthetic purposes and do not convey any important information or functionality to the user.

  ---

  • Since these images do not convey any important information or functionality, there is no need for an alt attribute.

  ---

  • So feel free to set the alt attribute as "" for decorative svg's, because alt="" will be skipped by screen readers they will consider the image as decoration

  ---

  Example:

  <img src="images/decorative.svg" alt="">
  
  

  <img src="./assets/images/icon-reaction.svg" alt="Reaction icon">
  👇
  <img src="./assets/images/icon-reaction.svg" alt="">
  
  

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  11

  Marked as helpful
• 

  Arif Faisal•580

  @arifaisal123

  Posted about 2 years ago

  A very good effort! However, you may want to check out different devices in the mobile responsive version (using chrome developer tools) as I found white padding/margin at the top where the purple section is not completely aligned.

  13