Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 11 months ago

Responsive single price grid component solution (SASS, BEM)

accessibility, sass/scss, bem
P
Denisse Joyce•290
@denissejoyce
A solution to the Single price grid component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I liked the button animation I added!

What specific areas of your project would you like help with?

I'd be so thankful to anyone who can review my use of BEM and semantic HTML (I'm trying to focus on accessibility also)!

Oh, and lastly, any tips on how you guys name your CSS/SASS variables, please? I understand that you have to be descriptive, but with projects that have lots of colors, for example, how do you name your variables?

Thank you 🫡

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • haquanq•1,565
    @haquanq
    Posted 11 months ago

    Hello @denissejoyce 👋👋👋

    Nice work on the challenge!! It is looking good and close to the design. I notice that you are using extra hidden heading (sr-only) and it is good practice (improve semantic).

    Here is my feed back for you:

    • About naming classes, instead of naming it with parent & child relationship, for each small section you can pick an unique name for it. For example,
    // you can flat it out to avoid deep nesting
    intro__section
        intro__title
        intro__subtitle
        intro__description
    subscription__section
        subscription__title
        subscription__price
        subscription__description
        subscription__link
    why__section
        why__title
        why__list
            why__item
    
    • About naming variables (colors), depend on the scale of the project you could simply name all the variants of each color such as color-500, color-600 and use them directly. Or if you want your system to be more robust you can define local colors variable for each component like item--clr-hover and use it for itself or child elements. However since you are using SASS, there are so many way to utilize functions/mixins to solve different problems. At the end, you need to practice a lot to figure out what do you need.

    Hope this help 🌴🌴🌴

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit 1st-party linked stylesheets, and styles within <style> tags.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub