Skip to content
Submitted over 4 years ago

Responsive site made with Sass and pure JS

Grzegorz Sterczewski•680
@gsterczewski
A solution to the Room homepage challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

I'm open to all feedback and critique. I know that my scss could be more concise, and html is little too bloated, plus my approach to handle the slider controls positioning is hacky at the moment. Also,naming thing in english is a real struggle for me. I'm curious what do you guys think about the responsivness and breakpoints that I set ?. For anyone taking the time to check out my solution: thank you. Cheers.

Code

Please log in to post a comment

Log in

Community feedback

  • ApplePieGiraffe•30,525
    @ApplePieGiraffe

    Hey, Grzegorz Sterczewski! 👋

    Good job! Your solution looks pretty good! 👏

    In addition to janez33's helpful feedback, I suggest,

    • Adding cursor: pointer to the mobile navigation menu icon.
    • Giving the slider buttons some more height in the mobile layout of the page to give the arrow icons inside them some space (as in the original design).
    • Preloading the slider images so that there is no delay between when the next slide is clicked and the image appears would be a nice touch!

    Keep coding (and happy coding, too)! 😁

  • Janez Kolar•140
    @janez33

    Hello I've looked at your solution :) I'm consider myself as a junior front-end developer and I have to say good job :) Here is one thing about responsivness - your solution doesn't look very good at 1000px viewporth width, there is too much white space at the bottom of the page. Setting media query to 1000px is not good for your solution I think and this is just my opinion. Your design doesn't look good on big screens from 1000px to 1600px. Width settings for .layout-wrapper doesn't do anything also height. Define your media queries before you start building the site (maybe look for some standard media queries you should always look) and then change positioning of the page to look good on those media queries and also device friendly. I hope I didn't say anything wrong. Keep building, every time you build something you are improving :) Regards from Slovenia

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord