@shubhamthedev
Posted
Hi, if you're using flex-box for this project then i don't think there is any other way to position logo on top other than to use position:absolute
. The site is responsive although i have some suggestions for you:
-
You should fix all the accessibility issues by providing a label for input and name attribute for button element.
-
The site is responsive on tablet devices although the image is very stretched and doesn't look good.
-
You forgot to add the background to the site.
Hope this helps and keep coding 👨💻
@heytulsiprasad
Posted
@tomboynotes Thanks for suggestions! However, I'm afraid there wasn't any background image in the starter files. And I'll fix these accessibility issues soon, as I'm new to this I didn't know how they worked.
@shubhamthedev
Posted
@tulsi-prasad maybe the background image wasn't there in your files but it's named bg-pattern-desktop.svg
.
You can find it in my repo.