Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive site with CSS Grid

#accessibility

@BhekiAccion

Desktop design screenshot for the Testimonials grid section coding challenge

This is a solution for...

  • HTML
  • CSS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Was coming along fine but lm not too happy with the end, not as good as l wanted it to look

Community feedback

Abdul 8,560

@Samadeen

Posted

Hey!! Cheers 🥂 on completing this challenge.. .

Here are my suggestions..

  • You should use <main class="container"> instead of <div class="container">.
  • Go down orderly when you are using the headings h1 down to h2 down to h3 and so on.
  • You can wrap your attribution section in a footer tag to avoid accessibility issues.
  • You should remove your p nested in your span

This should fix most of your accessibility issues and HTML

. Regardless you did amazing... hope you find this useful... Happy coding!!!

Marked as helpful

0

@BhekiAccion

Posted

Hey Abdul, thanks for the feedback, l really appreciate it. Yeah normally wrap the content inside the main tag l just forgot on this one, and ohh thanks l always wondered where l can put the attribution because l don't really want them in the main tag. Thank you so much for this feedback. l will grow from this.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord