Responsive social links page with html and css

Solution retrospective
Any feedback appreciated! Thank you
Please log in to post a comment
Log in with GitHubCommunity feedback
- P@mehmetcagriekici
I was actually make a comment 3 days ago on last Sunday but I had an emergency that affected my last 2 days also, but here we are. First of all I want to say that it is really good that you mix pixels and rems, but I think you use them in wrong places. Here is a helpful blog post about pixels, rems, and ems. "https://www.joshwcomeau.com/css/surprising-truth-about-pixels-and-accessibility/" Also, on 375 pixels, your card width also is 375px which is the full width of the screen which is not the required design, there are gaps between the edges of the screen and the card on horizontal axis. Finally, you are using CSS variables, which is really great! You can also you them for all kind of sizes, and even make them responsive with CSS "clamp()" without the need of media queries. One last thing, I think if you've approached this problem with mobile first design, you would have an easier time to adjust the responsiveness. Congratulations on your valiant solution!
Marked as helpful - @4glightning
Seeing your work and code made me learn a lot of things. I tried comparing your code to mine and your's is just better in Maintainability, Responsiveness and Scalability. Can you tell me what method do you use? is it traditional css or is it react that your are using?
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord