Responsive Social Links Profile

Please log in to post a comment
Log in with GitHubCommunity feedback
- P@nursh
HTML:
- the overall markup looks great
- I recommend changing the tags for the location and description in the info-container from div to a p tag for proper text semantics
CSS:
- Avoid setting absolute widths on elements. If the element grows and shrinks, set a max-width so it becomes responsive.
- Change the units of the font-size on the h1 from px to rem to make it responsive
- Remove the height on the .links-menu li and set top and bottom padding instead. You don't want to be setting explicit heights for elements.
- Remove text-align: center on the .links-menu li, .links-menu li a and .info-container. Just set it once on the .profile-container and all the children will inherit the property. The principle of don't repeat yourself
- @adan-abbasi
Great Work
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord