Renszo Camacho• 1,615
@RenszCamacho
Posted
Hiya 👋🏻 RizkyFirman.
Good job mate 👏👏👏. You have done a fantastic job on this challenge 👌, I like the animation cards and it’s very responsive 💯.
I have been digging into your code, you have used css-grid. Cool.
You have a horizontal scroll on a small and medium screen. I would put on the body an overflow: hidden to fix that.
You got many <div>. Just a suggestion in my humble newbie opinion. 😊
-
You could have a
<main>tag involving your code. The<main>element represents the dominant content of the<body>of a document. -
Your cards could be
<article>instead of just<div>
I hope, it helps.
Happy coding🧑💻
2
Rizky Firman Syah• 215
@firmansyahrizky
Posted
🖐️Hi @RenszCamacho Thanks for your concern about it. Now i know my bad. I'll dive it more.
0
