Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive Social proof section using grid, flexbox and keyframes

P
tediko 6,580

@tediko

Desktop design screenshot for the Social proof section coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hi! The task took me some time, but I had no problems doing it. Nevertheless, I have still a few questions. In the file named style-guide.md i found information about something called "body copy" and it should be font-size: 15px. Does it mean that my body element should have such a value and from that I should style the rest of the elements? Is combining grid and flexbox a popular practice? Or should I stick to one model. Sometimes it is easier to use a grid to control multi dimensions layout but the content is very easy to style with a flexbox. Feedback appreciated, thanks!

Community feedback

P
ApplePieGiraffe 30,545

@ApplePieGiraffe

Posted

Hey, tediko! 👋

Nice work on this challenge! I like the animations you added to your solution! 👏

I suggest,

  • Setting a max-width on the testimonial cards in the mobile layout so that they aren't too wide when the layout first changes from desktop to mobile.
  • Adding some margin or padding to the top of the page (rather than simply centering the content of the page) so that there's always some space between the top edge of the screen and the content of the page (even on screens with small heights).

Keep coding (and happy coding, too)! 😁

1

P
tediko 6,580

@tediko

Posted

@ApplePieGiraffe Thanks for the feedback!

0

@jemeneradev

Posted

As far as I know, you can combine flexbox and grid (or any other layout) with no problem. They are not mutually exclusive. If it helps get the job done, it's fair game. Now if you find yourself layering too many layouts, then it might be a good idea to rethink things.

Some of the issues that I see are:

  1. the font in the testimonies are not formatted to the design. (fix font size, and line height)

  2. find the way to use only 1 star image for a review component.(Consider a repeating background approach.)

Happy Codings!

1

P
tediko 6,580

@tediko

Posted

@jemeneradev Thanks for the feedback!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord