@pikapikamart
Posted
Hey, awesome work on this one. Layout in general looks great and it is responsive.
kens_visuals already gave great tips on this one, just going to add some suggestions as well:
- Avoid using
id
attribute as a selector in css because it is a bad practice due to css specificity. Useclass
to target elements. - The text after the
h1
could have just usedp
tag since theh1
is enough to describe the section. - When wrapping a text-content do not just use
div, span
to wrap it, use meaningful element like ap
tag if it just a regular text or heading tag if it is an heading. aside
is not really suited on this one. Normally, you would useaside
when there are certain links, controls that are placed somewhat on side of the site.
Aside from those, great job again on this one.
Marked as helpful