Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 1 year ago

Responsive static QR code landing page

Jamesolukanni•150
@Jamesolukanni
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)
Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Olaniyi Ezekiel•7,580
    @Ezekiel225
    Posted over 1 year ago

    Hello there 👋.

    Good job on completing the challenge !

    Your project looks really good!

    I have suggestions about your code that might interest you.

    Consider changing the background-color of the body element to hsl(212, 45%, 89%)

    body {
      background-color: hsl(212, 45%, 89%);
    }
    

    I hope it helps!

    Other than that, great job!

    Happy coding.

    Marked as helpful
  • Joyal James•265
    @silkcoder
    Posted over 1 year ago

    Your solution looks good

    I have a suggestion about the max-width property you given to body tag.

    If your solution opened in a screen with width greater than 1440px, the content not get centered. So you can remove the max-width property of body tag

    body {
       //remove
       max-width: 1440px;
    }
    

    Once you remove this property, your content remains on cener for all sized devices.

    Another point

    To center the container its wise to use Flexbox properties, read more about it on the page https://www.geeksforgeeks.org/introduction-to-css-flexbox/

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit 1st-party linked stylesheets, and styles within <style> tags.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub