@darryncodes
Posted
Hi Alcpereira,
Overall a really decent solution - nice work!
Some feedback for you:
- add
display: block;
to your image, this will remove the 4 pixels difference - add
mix-blend-mode: multiply;
to.hero-banner > picture::after
and remove theopacity
to match the image colour with the design file - regarding the transition from desktop to mobile, one solution would be to bring your media query in as soon as the image gets squished. Another solution would be to use relative units (REM) not absolute units (px) to help the design scale
- here is a good video and an article that goes into the REM concept
Good luck with it all