Benjo Quilario• 1,810
@benjoquilario
Posted
Hi! Martins, great job on finishing this one, it looks good.
some suggestion to improve your code and responsiveness:
I did some changes in dev tools:
- You need to change the grid-template-column
1fr 1fr
value into fraction here the link to understand more about grid fraction. grid fraction. - you need to set your
main
width:100% and then add max-width: 876px so that it will response when the viewport is 876 - add another 100% to your
.image
classbackground-size: 100%
intobackground-size: 100% 100%
- Use unordered list <ul> for .subtitle. HTML lists are used to present list of information in well formed and semantic way.
Overall you did well, Hope this help!
cheers, benjo
Marked as helpful
1
Martins• 50
@RafaelMartins77
Posted
@benjoquilario Thank you for the tip;)
0