Responsive Tailwindcss Product Card

Hey there! 👋 Here are some suggestions to help improve your code:

• Unless if your company requires you to use a library , I strongly suggest you stay away from using libraries until you fully grasp the fundamentals of HTML, CSS and JS. By using a library, you are robbing yourself from actually learning how to code.

• To not only improve your HTML code but to also identify the main content of you page, you will want to wrap your entire component inside the Main Element.

• The image’s “Alt Tag” description needs to be improved upon to better describe what it is. You will want to assume that you are describing the image to a someone.

• This component requires the use of two images 🎑 at different breakpoints. The Picture Element will facilitate this.

Here is an example of how it works: EXAMPLE

Syntax:

  <picture>
    <source media="(min-width: )" srcset="">
    <img src="" alt="">
  </picture>

More Info:

https://www.w3schools.com/html/html_images_picture.asp

https://web.dev/learn/design/picture-element/

• Currently, the old price (169.99) 🏷 is not being properly announced to screen readers. To fix this, you are going to wrap the the price in a Del Element and inside it you will add a Span Element with an sr-only class that will state something like “The previous price was…” and use CSS to make it only visible to screen readers.

If you have any questions or need further clarification, feel free to reach out to me.

Happy Coding! 🍂🦃

Hi Marco Lizardo Del Riego,

Congratulation on finishing your first challenge.

Great job on this one! you have already received some helpful feedback which is nice to see , just going to add some suggestions as well if you don't mind:

• It's not recommended to capitalize in html, let css text transform take care of that. Remember screen readers won't be able to Read capitalized text as they will often read them letter by letter thinking they are acronyms.

• The cart image in the button is a decorative image. For decorative svgs, you set anaria-hidden=”true” and focusable=”false” to remove that element from the accessibility tree. This can improve the experience for assistive technology users by hiding purely decorative svgs.

• Adding rel="noopener" or rel="noreferrer" totarget="_blank"links. When you link to a page on another site using target=”_blank” attribute, you can expose your site to performance and security issues.

hopefully this feedback helps.