@laceeder
Posted
https://css-tricks.com/snippets/css/complete-guide-grid/
this helped me understand Grid when I worked on a project in the course I'm taking! It's very thorough and breaks it all down. There's also a lot of great youtube videos too.
Some tips: When you're writing your html, make sure to remember to write in a way that'll make sense to someone else looking at it. For instance, why use the graduates' last names? What does "bold-para" mean? And remember, it's best practice to use "-" and no spaces in your div classes and ids. Keep your names short, sweet, and to the point :)
You also must follow the style guide. This is why your desktop view looks big. The h1, h2, h3, h4 are all using default font sizes instead of setting your default font size to 13px like in the style guide. You also didn't call your font correctly when doing "font-family", so this also will affect the size and general appearance of your work because it's not inputting the font because it doesn't just know "Barlow", you have to say "Barlow Semi Condensed, sans serif" for it to work properly.
Also make sure to leave the <html lang="en"> at the top of your html document in that file, it gives an error for accessibility issues.
Other than that, everything else looks really great! You've done a great job! Keep learning and good luck! :) I was actually looking at your code for guidance on my own version of this challenge!
Marked as helpful
@Heph-zibah
Posted
@laceeder
Thank you for taking out time to review the code.
"Also make sure to leave the <html lang="en"> at the top of your html document in that file, it gives an error for accessibility issues." I am not sure I understand this part though. Do you mean I should remove the doctype?
I do take all your suggestions to heart and I promised some improvement in my next ptoject. Do well to check it out. I should submit by tomorrow.
Thnak you so much for this comprehensive suggestions
@laceeder
Posted
@Heph-zibah Hello! You're very welcome! :) Also, make sure to go in numerical order when using h1-h4 and so on. Then go in the CSS and change the font sizes to make them bigger or smaller. That way it will not create a semantics issue.
about the <html lang="en"> tag, I don't understand myself why it's accessibility issue, I was just looking at the report link on here on my end. Here's the link: https://www.frontendmentor.io/solutions/responsive-testimonial-grid-section-using-html-amd-css-grid-kjs3LIdCgu/report
Leave the doctype in, don't remove it. That tells your file what type of file it is in whatever code editor you're using, as well telling the website what type of file it is.
Marked as helpful
@Heph-zibah
Posted
@laceeder
Alright. Thank you
