Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive testimonial page using HTML and CSS grid

#contentful#materialize-css
Augustine Asareβ€’ 120

@AustinKing5

Desktop design screenshot for the Testimonials grid section coding challenge

This is a solution for...

  • HTML
  • CSS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


  1. when it comes to writing clean codes, is it about it achieving the intended solution with shorter codes or readability?
  2. how can i Improve my ability to write clean codes?

Community feedback

Lucas πŸ‘Ύβ€’ 104,580

@correlucas

Posted

πŸ‘ΎHello @AustinKing5, congratulations on your new solution!

Your html is working but you can improve it using meaningful tags and replace the divs, for example the main div that takes all the content can be wrapped with <main> or section, about the cards you can replace the <div> that wraps each card with <article> you can wrap the paragraph with the quote with the tag <blockquote> this way you'll wrap each block of element with the best tag in this situation. Note that <div> is only a block element without meaning, prefer to use it for small blocks of content.

This article from Freecodecamp explains the main HTML semantic TAGS: https://www.freecodecamp.org/news/semantic-html5-elements/

✌️ I hope this helps you and happy coding!

1

Augustine Asareβ€’ 120

@AustinKing5

Posted

@correlucas Thank you for introducing me to semantic HTML. It has really improved my coding and made it easier for me to style my projects.

0
Nneoma Njokuβ€’ 1,210

@SatellitePeace

Posted

Hello @AustinKing5

Your code looks good except for the fact that it is not responsive

*** to answer your question ***

  • A clean code is basically, a scalable, maintainable, readable, and easy-to-understand code

  • So yes writing a clean code means writing a code that others can read

  • clean code does not always mean shortcodes, if writing short code means you have to cut corners and use certain hacks then don't write shorter codes because it will make your code difficult to read, understand and maintain

  • However, if refactoring your code to be shorter follows best practices and does not involve hacks and cutting corners then by all means write shorter codes

  • I tried to see why your site is not responsive but I could not access your GitHub so either the link is incorrect or the repo is set to private

I hope these explanations help

1

Augustine Asareβ€’ 120

@AustinKing5

Posted

@SatellitePeace Your explanation is very helpful and I am happy to say, I come back to it all the time. Thank you very much. I have updated the solution .

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord