Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Cannot read properties of null (reading 'code')
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive Testimonials Grid

Lauryne 260

@lauryne921

Desktop design screenshot for the Testimonials grid section coding challenge

This is a solution for...

  • HTML
  • CSS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Tell me what you think if the responsive is good or not. I liked doing this project so if something is wrong tell me

Community feedback

Joanna 370

@JoannaLapa

Posted

Hi LAURYNE’S,

congratulations on completing the project! This is the best way to make the progress.

Concerning your question - I suggest you to correct the mobile layout. Try to use Mobile First approach which is a good practice. Your solution with @media screen and (max-width: 375px) cause that all screens over 375 px (so even 376px) have desktop layout and everything is very very small. My suggestion is to prepare at first styles for mobile layout and after change the layout for bigger sizes with eg. @media screen and (max-width: 560px) etc. If you're not familiar with Mobile First approach you can read more about here.

Other suggestions to improve your code:

  1. You don't need to repeat yourself with background-color, color and other design styles which are the same for all sizes - you can delete them from @media, because you styled them already in general code.

  2. To divide your articles (.one, .two, .three, .four) you can use gap on parent (.wrapper in your project) instead of margin (much less code). Gap works for grid and flex - you can read more here on mdn

  3. Instead of code: grid-column-start: 2; grid-column-end: 4; grid-row-start: 2; grid-row-end: 3; you can simply write a shorthand: grid-area: 2 / 2 / 3 / 4 more about grid-area here

  4. I feel that making position fixed on body and position absolute on global-content is not necessary.

  5. I can recommend you a video from Kevin Povel where he made exactly this project explaining by the way many grid cases, I think that it can be useful for you. And by the way I recommend you Kevin Powel's youtube canal, there is a lot of useful css tricks. Here is the video with this project.

I hope that my comment was helpful! Happy coding ;) Joanna

Marked as helpful

1

Lauryne 260

@lauryne921

Posted

@JoannaLapa Hi Joanna ! Thanks a lot for your comment ! I'll try to start by mobile first next time, that's true I wrote again the background-color and color so I will delete that and thank you I didn't know about grid-area ! And I'll check the youtube channel I think it can be very useful so thank you for your comment ! Have a good day !

0
Lucas 👾 104,560

@correlucas

Posted

👾Hello @lauryne921, congratulations on your new solution!

Your html is working but you can improve it using meaningful tags and replace the divs, for example the main div that takes all the content can be wrapped with <main> or section, about the cards you can replace the <div> that wraps each card with <article> you can wrap the paragraph with the quote with the tag <blockquote> this way you'll wrap each block of element with the best tag in this situation. Note that <div> is only a block element without meaning, prefer to use it for small blocks of content.

This article from Freecodecamp explains the main HTML semantic TAGS: https://www.freecodecamp.org/news/semantic-html5-elements/

✌️ I hope this helps you and happy coding!

0

Lauryne 260

@lauryne921

Posted

@correlucas Okay thank you for your help ! I will use your advice for improve my code and my futures codes !

0
Lauryne 260

@lauryne921

Posted

@correlucas Hi again ! I have a question, the responsive is good but I can't scroll on my phone so is it because of the grid or do I have to add something in the CSS ? Thanks for your help !

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord