@correlucas
Posted
👾Hello Elaine, congratulations for this pixel perfect solution!
🕵️Is hard to point something in your solutions because they're ever clean and consistent. But in this case there's only a detail that you probably did on purpose, that are the borders around the profile photo, the only photos that have it are the purple and black one, but I'm sure you add to the others because look better like this, so my bad! 😅
🧓 For the card semantics I guess you probably know it too, but you can replace the card divs with article and the paragraph with blockquote (this is amazing, someone told me that last week and I didn't knew exists a specific tag for quotes).
🤯 I usually propose people to do a media query for tablets, but you went far and did two aditional layouts for the grid. Really impressive.
I come to try to leave you a feedback but ended that I learned a lots.
Congrats and happy coding!
Marked as helpful
@elaineleung
Posted
@correlucas Thank you Lucas, I always appreciate your feedback! I struggled with those profile photo outlines as I couldn't find the colors for them, and I think the other ones are too light to be seen, especially the white ones. I should have a look at your solution to see which colors you used 🙂
And yes, great point regarding the article element, which would be fitting here. I have heard of blockquote but haven't used it actually, so I think I'll try it out when I update this solution!
@correlucas
Posted
@elaineleung Ah, thats amazing. I don't know if you already do it, but Figma is amazing even if you don't have the design files, because you can eyedrop all colors and create rectangles to measure components or even see small details like paddings and border-radius. Of course is nothing like the design files from the pro subscription, specially for big projetcs, but its better than nothing hahaha
