@dmitrymitenkoff
Posted
Hi Tomiwa,
This is an awesome project - great job! I'm not a JS expert, but your code looks maintainable, you avoid repetition, provide good (and useful) comments and separate the concerns. I've just recently completed the same challenge, and I was really interested in the way you implemented the Tip selection section. I used (and struggled quite a bit with) radio inputs. I notice you opted into using the real button element with data value attributes. This is such a cool way of doing the 'select' section. I wonder if there are any accessibility issues with this approach?
Once again, well done!! Cheers
Marked as helpful
@tomiwaorimoloye
Posted
@dmitrymitenkoff thanks a lot bro! Yeah, I also noticed I kept repeating some statements but I just wanted to get the project done with😂 I don't think there are any major accessibility issues with my approach because, buttons can still be accessed with the keyboard while using the tab key. And the accessibility report didn't see anything wrong with my approach either. So I think it's okay. Thanks again for the feedback man!
@dmitrymitenkoff
Posted
@tomiwaorimoloye Totally, good point about the tab key! I will definitely use the button approach in a similar context next time! cheers!
