@macdeesh
Posted
Hi Elaine, this looks really nice ! Very good work !! Bravo !!
In case the amount of the bill is a big number like more than 7 zeros, the result of the calculation in Tip amount/person and total/person is too long and take place over the calculator, to fix this add an overflow-x: scroll on the amount fields.
You forget to make the error message when the number of people is not added or 0. Or maybe it's by choice ?
Marked as helpful
@elaineleung
Posted
@macdeesh Thank you for letting me know about large numbers; I might opt to make the font size smaller in that case instead of using overflow: scroll, but that is certainly an option!
Yes, the omission is by choice. I initially had that in my function, but when I looked at the design again and compared the empty and active states, there's no error message when the state is empty; it's only there when 0 is actually an input. It's also a better user experience without the error message in empty state; when I was testing it and whenever I deleted the previous input, the message would show up each time, and it felt like it was too "in your face" and annoying. It made me want to quickly input a number just so I won't see the message 😅. It's never good when users get annoyed!
@elaineleung
Posted
@macdeesh Hi Macdeesh, I fixed the overflowing digits, so if you want to give it another test, feel free to do so 😊
@macdeesh
Posted
@elaineleung Hello Elaine, I just tested again, and it's perfect !! I prefer your solution to the overflow-x: scroll
, for a better user experience. Well done !
@elaineleung
Posted
@macdeesh Thanks again for catching it 😊