@0xabdulkhalid
Posted
Salaam Alaikum π. Congratulations on successfully completing the challenge! π
- I have a suggestion regarding your code that I believe will be of great interest to you.
PROVIDE VISUAL CLUE DURING FOCUS :
- I want to address the current issue with focus states for interactive elements like
button
anda
. Whenever i try to access them using keyboard (tab key) i can't even see which element is currently on focus.
- It's an important thing to fix, because people who relay on accessibility devices will find hard to navigate elements through the website without any visual clue for interactive elements.
- We can simply fix this by adding this general rule,
:is(button, a):focus-visible {
outline: black dotted 3px; // You can choose whatever color.
outline-offset: 0.25rem;
}
- With the help of this custom css rule, we can help the people to easily navigate throughout our website
- Additionally i want to address another issue regarding the
Select Tip
buttons, because they are all currently build withdiv
elements actually they need to bebutton
elements. So please change them intobutton
element to improve overall accessibility
.
I hope you find this helpful π Above all, the solution you submitted is great !
Happy coding!
Marked as helpful
@atif-dev
Posted
@0xabdulkhalid Thanks for the feedback β€. I will look into your highlighted points.