Responsive URL shortening website using ReactJS and SCSS

Solution retrospective
I'd really love a feedback. I challenged myself to do this with ReactJs. Let me know if you think I delivered this properly. Is there something you feel I should have done differently?
Please log in to post a comment
Log in with GitHubCommunity feedback
- @carlwicker
Great job, there are however a few other issues I would consider fixing.
- The input field validation doesn't always work, it should revalidate on every change.
- And submit on Enter key press for the input field would help accessibility.
- on clicking the submit button with incorrect data the input breaks and is no longer usable.
Finally fix those accessibility and HTML issues in the report.
Layout look good, great work.
Marked as helpful - @skyv26
Hi! Favour, you made it really nice and you did it using Reactjs (Iceing on the cake).
Suggestion
-
For each navigation menu give idea of each section of this challenge to each menu anchor' tag href. So that if someone click on menu then that particular menu takes user to that particular section.
-
Your social media icon at the bottom is not aligned properly to center. So make it center.
Overall 7/10 Good Job 👍
Marked as helpful -
- @phaevourkhris
Hi @skyv26 thanks for the feedback, but I don't quite follow.
There's barely any sections relating to the menu buttons in the nav bar, that is why they weren't linked. Seeing as we only worked on the landing page. I assumed that those menus will link to other pages.
Also, From the design, I don't quite see the social media icons aligned to the center for the desktop screen. Except you're referring to a smaller screen size. So if you'd please make me understand what you mean better, I'd appreciate that.
Thank you
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord