Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 2 years ago

Responsive using flex , margin , padding , min-height , and more

Suphakrit Boonlar•10
@Fakemilaz
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Q : What did you find difficult while building the project? A : make card center and using margin , padding , min-height , flex

Q : Which areas of your code are you unsure of? A : min-height , flex

Q : Do you have any questions about best practices? A : margin , padding , min-height , flex

Code
Loading...

Please log in to post a comment

Log in with GitHub

Community feedback

  • Nneoma Njoku•1,210
    @SatellitePeace
    Posted over 2 years ago

    `Hello @Fakemilaz your card looks nice

    • min-height specifies the minimum height the body of your content should have

    • adding min-height to your body tag ensures that the length of your entire content shows and if your content length is more than 100vh the user will be able to scroll to see the entire content

    • For you to center your card with flex you have to add a height or min-height, you also need to add the justify-content property in addition to the align-items property

    • this is to ensure that your card is centered both horizontally and vertically

    • Also add a margin to the body so that the card will have some space from the body in a smaller screen

    • like the example below

    
    body {
        background: hsl(212, 45%, 89%);
        min-height: 100vh;
        display: flex;
        align-items: center;
        justify-content: center;
        margin: 2rem,
    }
    
    • Also when you add a max-width you should also add a width of 100% so that in screen sizes below 375px your card will adjust and still look good

    .container { max-width: 375px; width:100% margin: 0 auto; }

    
    Overall you used flex, and margins properly 
    
    - Do not use px for font-size use rem or em units instead
    
    I Hope This Helps
    

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub