@christopher-adolphe
Posted
Hi @tiffanicodes, 👋
You did a nice job in completing this challenge. 👍 I have recently completed the same project and I think I can give you some tips on how you could improve your solution or at least think of a different approach.
- I see that you have built the main content section using the
grid-area
property from CSS grid. While this is not a bad approach, it is not a flexible solution. Here are 2 resources that will surely help you come up with a more efficient layout. Travis Horn - Responsive grid, CSS-TRICKS - Responsive Grid - In order to render the hero title in black and white, you can apply the
mix-blend-mode
property. It can have different values depending on the result you want to get, in the case of this challenge, theexclusion
value does the job. 😉 Read more about it here. - The spacings in the footer section need to be reviewed as at the moment it looks wider than the header and main sections. I would suggest that you add a wrapping
<div class="container">
element inside the different sections of your page to which you then apply amax-width
. This will resolve the problem as well as on thelocation
page. - On the CSS side, I would suggest that you refrain from using
id
as selectors to style elements as this hinders reusability.
I hope this helps.
Keep it up.
Marked as helpful
@tiffanicodes
Posted
@christopher-adolphe Thank you so much!! This was incredibly helpful and I really appreciate you sharing those resources. I will definitely check them out and see how I can improve.
@christopher-adolphe
Posted
Hi @tiffanicodes,
I'm happy to help and glad to see this was helpful to you. 🤝
Don't hesitate to dive into my git repository for this challenge, you may also find something useful there. 😉
See you on the next one.
Best regards.