Responsive Website Using CSS Grid And Flex

Community feedback

• 

  Raymart Pamplona•16,040

  @pikapikamart

  Posted almost 4 years ago

  Hey, great work on this one. The layout both desktop and mobile is good and the responsiveness as well.

  Some suggestions would be:

  • The company logo's alt text should have been alt="Fylo" since the logo itself have that word, better to use it in the alt. Also, when using alt attribute, do not include words like "icon" "image" "logo" or anything else that relates to "graphic", assistive tech will handle those for you.
  • The company logo in the header as well, since you are adding an interaction with it, better to nest it inside a tag, along with an aria-label="homepage", since mostly company logo links to the homepage.
  • Have a main element that wraps the whole main content. This will clear up the issue in your report as well as adding more to the structure of your website.
  • Do not skip a heading level. Use heading tags incrementally by one. If you use h1 make sure to have h2 before you use h3. On your solution, you didn't use h3 but you used h4 and h5.
  • The alt text for the person in the testimonial could have used their name as the value, like alt="Satish Patel".
  • Only use 1 h1 per page. You use the 1st h1 on the hero-section, the 2nd one is at the cta-section.
  • On the submit button in the form, it would be better to use button type="submit", the reason is that, you could add a more descriptive information about what that button does, you could add aria-label="submit form" on the button instead of just get started for free which doesn't really describe what it does right.
  • Company logo in the footer could have used alt="fylo" as well.
  • The links on the footer could have used ul as well, since those are list of links.
  • The a tag that holds the social media icons should have an aria-label, like aria-label="facebook" for the a tag that wraps the facebook icon. This will ensure that screen reader users knows where this link should go.

  Aside from those, great work.

  00