Responsive with Grid elements

Community feedback

• 

  P

  webdevbynight•530

  @webdevbynight

  Posted 8 months ago

  Some feedback:

  • beware of relative paths starting with /: they start from the website root and, as you host your challenge on GitHub Pages, where it is hosted in a directory, the images do not appear (start the relative paths with ./ to resolve the problem);
  • some elements from the design are missing: the “ in the purple card background and the box shadows for some cards;
  • the grid container should have a maximum width for it does not stretch too much on very wide screens like a 27-inch one;
  • you should avoid using the height property to set the height of blocks containing and instead use min-height: if the contents are long enough, they can overflow when a fixed height is used for their container;
  • when using grid-template-areas, try to give the areas more semantic names (imagine testimonials change with different names);
  • when naming a class, for the same reason as above, use class with semantics in mind (I am talking about the classes named following the names of the people leaving a testimonial).

  I hope this feedback helps you.

  10
• 

  nimbo•100

  @7bibi

  Posted 8 months ago

  Good job. The pictures are not showing.

  10