@Islandstone89
Posted
HTML::
-
Every webpage needs a
<main>
that wraps all of the content, except for<header>
andfooter>
. This is vital for accessibility, as it helps screen readers identify a page's "main" section. Replace<section>
with<main>
. -
"Learning", "Published" and "Greg Hooper" are
<p>
elements. If they were headings, they must have been in order. -
"These languages" is also a
<p>
. -
Profile image needs a short alt text, for example "Headshot of Gary Hooper".
CSS:
-
Including a CSS Reset at the top is good practice.
-
I like to add
1rem
ofpadding
on thebody
to ensure the card doesn't touch the edges on small screens. -
Move the properties on
.all
to.container
, and remove the margin. Addmin-height: 100svh
on thebody
, so the card has vertical space to center itself. -
Instead of using elements or
nth-child
as selectors, I would assign classes on the different elements. -
font-size
must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead. -
line-height
must also never be inpx
. -
The top image should have
display: block
andmax-width: 100%
.
Marked as helpful