Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive-fylo-data-storage-component-made-with-CSS-Grid-system

#sass/scss

@Kamasah-Dickson

Desktop design screenshot for the Fylo data storage component coding challenge

This is a solution for...

  • HTML
  • CSS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Dear frontendmentors it has been a days now. Am here with a new solution, and i think your opinions will really help improve me. What do you really think about this solution? Don't forget to like and comment :)

also this is a link to my previous solution check it out please :(

https://www.frontendmentor.io/solutions/responsivesocialmediadashboardwithdarkmodetoggle-HJrHNiAM5

please don't forget to like and comment on it thanks fam :)

Community feedback

Ivan 2,630

@isprutfromua

Posted

Hi there. You did a good job 😎

keep improving your programming skills🛠️

your solution looks great, however, if you want to improve it, you can follow these steps:

✅ it is better to use a single style of access to elements (classes, or idi)

let input = document.querySelector ('input')
let volume = document.getElementById ('volume')

✅ It is better to delete comments from the repository

// progress.style.left = (input.value / 1.1) + '%'

✅ Try to avoid oninput, it is better to use addEventListener instead.

✅ For security reasons, it is better to install textContent instead of innerHTML

I hope my feedback will be helpful. You can mark it as useful if so 👍

Good luck and fun coding 🤝⌨️

1

Amine 90

@UsernameUTF

Posted

@isprutfromua ok Thanks bro

0
Ivan 2,630

@isprutfromua

Posted

@UsernameUTF I'm glad that my comment was helpful to you.

Contact me if you have any questions

Cheers

0
Amine 90

@UsernameUTF

Posted

@isprutfromua thanks ok

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord