REST Countries API app with Dark Mode

Community feedback

• 

  Travolgi 🍕•31,320

  @denielden

  Posted about 3 years ago

  Hi Raj, good job! I took some time to look at your code and have some ideas for improving it:

  • add main tag and wrap the content of page for improve the Accessibility
  • in the details page border countries are missing
  • add discernible text to Buttons and hide with hidden class
  • to make it look as close to the design as possible remove .p-5 class to div of card country and use another div with .p-5 for the under text information
  • the background of dark mode doesn't cover the whole page but only the beginning
  • if you want to use the capital for the href attribute you have to parse it in url, it can give problems creating links with empty spaces or special characters
  • if I type a query that doesn't give any results, nothing happens, try adding a "no results" message
  • I would also add a query reset button, I find it very convenient
  • to make all flag images the same height use the object-fit: cover property

  Overall you did well 😉

  Hope this help and happy coding!

  01

  Marked as helpful