@wendyhamel
Posted
Hi there, very nice try, but there is still room for improvements.
You could look at the accessibility report. It can improve your use of semantic HTML. The HTML validation report can be useful too but can show errors related to React in your case.
You should check your console while working on this project. There is a lot showing up, errors and logs, the console should remain clean when the site works as it should.
The site crashes when you search some country that is not found with a filtered region (intentionally entered a non-existing one here, just random letters like ‘dfgwxemr’).
These are some major things you should take care of.
Some more minor things:
- You should give the search input a type of
search
instead oftext
- Time of the animation fade in of the flag when you pick a single country is a bit long if you ask me
- Hover effect on dark/light mode the edges come too close to the text and icon, makes it feel cramped
- As mentioned by @avinasdv the position of trailing grid items. Another possible solution is to switch flex for grid.
- Align the search input and the filter with the edges of the country cards on the largest size
Hope this will help you improve!
Happy coding!
Marked as helpful