Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 11 months ago

Rest countries api with color theme switcher master

axios, react, react-router
Yejin Han (한예진)•270
@Yejin-Han
A solution to the REST Countries API with color theme switcher challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What challenges did you encounter, and how did you overcome them?

When I deploy to github pages, it showed 'Unexpected Application Error! 404 Not Found' error. To solve this problem, changed package.json and basename almost 10 times and solve it. And last time I used React was almost 1 and a half year ago, so it was hard to adapt to it.

What specific areas of your project would you like help with?

Anything you've found! Thank you :)

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Teodor Jenkler•4,040
    @TedJenkler
    Posted 11 months ago

    Hi @Yejin-Han,

    Nice project! I really like your custom select with animation and the detailed regions. Here are a few things I noticed:

    Small Fix: The cards under the flag have no borders, which affects the user experience, especially for countries like Indonesia. Adding a light border or a slim shadow effect could improve this.

    Responsiveness: The first page looks great and is very responsive—well done with the grid. However, the selected flag section has some issues. There are several small breakpoints where things look slightly off, and larger breakpoints, like at 800px wide, where the layout breaks. This could use some attention.

    JavaScript and Framework: I noticed you used Create React App for this project. While it’s used by some, many developers find it a memory hog and compatibility problem, making it less effective as a bundler. I’d recommend using Vite instead. You can set it up with npm create vite@latest and choose your project configuration.

    Overall, great job. Hope this feedback helps!

    Best, Teodor

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub