Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

REST Countries API with color theme switcher solution

#react#sass/scss#webpack

@mrfinesse47

Desktop design screenshot for the REST Countries API with color theme switcher coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
4advanced
View challenge

Design comparison


SolutionDesign

Solution retrospective


What do you think of this solution attempt?

Community feedback

Travolgi 🍕 31,480

@denielden

Posted

Hi Kevin, great work on this challenge! 😉

Here are a few tips for improve your code:

  • remove all unnecessary code, the less you write the better as well as being clearer: for example the figure tag container of flag image
  • you can use ul instead multiple p tag for the details of country
  • instead using margin to Country class for separate the cards try to use gap: 3rem to .country-list class
  • instead of using px use relative units of measurement like rem -> read here
  • if I type a query that doesn't give any results, nothing happens, try adding a "no results" message
  • I would also add a query reset button, I find it very convenient

Overall you did well 😁 Hope this help!

1

@mrfinesse47

Posted

@denielden thank you for the feedback, i'm ready to swear off pixels for the next project. The ul is a good idea as well for a list of details, i'm not sure why I didn't think of that. The search input can be improved as well I agree.

1
Travolgi 🍕 31,480

@denielden

Posted

@mrfinesse47 You are welcome! Keep it up ;)

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord