REST countries api, without modal

Solution retrospective
I would like to know: -> better way to do search and filter function -> my solution does not cover modal part when each country card gets click because I still don't know how to do that yet. If you have done this challenge, I'd like to learn from you solution. Any other feedback is greatly appreciated!
Please log in to post a comment
Log in with GitHubCommunity feedback
- @denielden
Hi Duyen, great work on this challenge! 😉
Here are a few tips for improve your code:
- use
p or ul
tag for the data of card of country instead adiv and span
element - add descriptive text in the
alt
attribute of the image - if I type a query that doesn't give any results, nothing happens, try adding a "no results" message
- I would also add a query reset button, I find it very convenient
- in the filters there is no way to return to all countries after choosing a region, add an entry "all region"
- to make the details page you can use an
a
that passes the data to the linked page or you can generate an event with javascript that opens a new page onclick
, passing it the country data and then cycling them on the page
Overall you did well 😁 Hope this help!
Marked as helpful - use
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord