Travolgi 🍕• 31,460
@denielden
Posted
Hi Duyen, great work on this challenge! 😉
Here are a few tips for improve your code:
- use
p or ul
tag for the data of card of country instead adiv and span
element - add descriptive text in the
alt
attribute of the image - if I type a query that doesn't give any results, nothing happens, try adding a "no results" message
- I would also add a query reset button, I find it very convenient
- in the filters there is no way to return to all countries after choosing a region, add an entry "all region"
- to make the details page you can use an
a
that passes the data to the linked page or you can generate an event with javascript that opens a new page onclick
, passing it the country data and then cycling them on the page
Overall you did well 😁 Hope this help!
Marked as helpful
0