Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 2 years ago

REST Countries API(Vite + React JS + React Router + SCSS + leaflet)

accessibility, axios, react, react-router, sass/scss
P
mohamed yasser amer•610
@mohamedyasser27
A solution to the REST Countries API with color theme switcher challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I found that implementing a reusable dark theme hook to be challenging, particularly when it came to utilizing SCSS. After much experimentation, I discovered a mixin that generated CSS custom properties, which helped me overcome this hurdle.

also, while developing functions to manipulate the country data, I realized that I wasn't entirely confident about the way I had written the code. I felt that I could benefit from some guidance on best practices in this area.

I would like to learn more about the recommended approaches to structuring project folders and ensuring accessibility. By implementing best practices in these areas, I hope to create cleaner, more efficient, and more scalable projects in the future.

i also want to know your opinion on the whole project responsive design.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Emmanuel Daniel•1,170
    @coderdannie
    Posted over 2 years ago

    Hello Congrats on the completion of this project. You did a great Job. My suggestion is as follows

    1. While data is still been fetched from the API, before the data arrives, you can render loading spinner or something of a simple text like 'loading...' just to make your app more user friendly in terms of users experience.
    2. Also you can as well handle errors in a more obvious manner. Right now if I should input a country that doesn't exist, it doesn't just display anything. It seems blank. You can implement a ui error as well like ' no country found for your query". You can as well check my solution so see the suggestions I made. I also implement this suggestions https://rest-countries-coderdannie.netlify.app/ Overall you did a great job Happy coding
    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub