Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

REST COUNTRIES APP with theme switcher using React and SASS

#react#sass/scss

@FelixGonzalo

Desktop design screenshot for the REST Countries API with color theme switcher coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
4advanced
View challenge

Design comparison


SolutionDesign

Community feedback

Travolgi 🍕 31,500

@denielden

Posted

Hi Felix, great work on this challenge! 😉

Here are a few tips for improve your code:

  • Links must have discernible text, you can add with sr-only or hidden class
  • add main tag and wrap the cards for improve the Accessibility
  • instead of using px use relative units of measurement like rem -> read here
  • if you want to use the title for the href attribute you have to parse it in url, it can give problems creating links with empty spaces or special characters
  • if I type a query that doesn't give any results, nothing happens, try adding a "no results" message
  • I would also add a query reset button, I find it very convenient

Overall you did well 😁 Hope this help!

Marked as helpful

0

@FelixGonzalo

Posted

@denielden Thanks for the help !! 😄

1
jay 210

@Jay-0331

Posted

Hello 👋🏻,

For Html issue for a tags href use alpha3code for it as it is much better.

Everything else is perfect. Great job 👍🏻

Happy Coding🥳

0

@FelixGonzalo

Posted

Thanks @Jay-0331 😁

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord