Travolgi 🍕• 31,500
@denielden
Posted
Hi Felix, great work on this challenge! 😉
Here are a few tips for improve your code:
- Links must have discernible text, you can add with
sr-only or hidden
class - add
main
tag and wrap the cards for improve the Accessibility - instead of using
px
use relative units of measurement likerem
-> read here - if you want to use the title for the
href
attribute you have to parse it inurl
, it can give problems creating links with empty spaces or special characters - if I type a query that doesn't give any results, nothing happens, try adding a "no results" message
- I would also add a query reset button, I find it very convenient
Overall you did well 😁 Hope this help!
Marked as helpful
0
Felix Castro• 40
@FelixGonzalo
Posted
@denielden Thanks for the help !! 😄
1