Looking to hire developers?
Hi Everyone, I would entertain feedbacks, constructive criticism and questions. Thank you.
@JesusAtao96
Posted
Hello Abiodun Olunu 👋
Excellent work on this challenge 🎉🎉🎉.
Try to integrate a debouce for the input search, this makes the request be called when the user stops typing. Currently in your solution for each letter written a request is being made and that is bad for a real project,.
Your backend will appreciate it very much ✨.
Happy coding 😊.
@abiodunolunu
Posted
@JesusAtao96 Thank you ♥
@santos-jadson
Posted
Hello, Olunu! How u doing?
Your code is great and looks very similar to the original design. Congrats :D ... I think the only thing you could check is the fact that some of the cards don't have the same height. Maybe if you set a min-height or a max-height property, it could be fixed.
@abiodunolunu
Posted
@santos-jadson Thank you, The main reason why I did it that way is because of the flags, they aren't the same heights and widths and I don't want to hide parts of any flag. But I will rectify this ASAP. Thanks
@ApplePieGiraffe
Posted
Hello there, Abiodun Olunu! 👋
Nice work on this challenge! 🙌 Your solution works quite nicely! I like the loading animation you added when waiting for countries to appear! 👍
I just suggest adding cursor: pointer to the country cards perhaps giving them a maximum size so that they do not become too big in the desktop layout if only one country is shown. 😉
Keep coding (and happy coding, too)! 😁
@abiodunolunu
Posted
@ApplePieGiraffe Thanks for the feedback, I will do that ASAP.
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord
