Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

rest-countries-api-with-color-theme-switcher using React.js

#react
Sai Pradeepti• 130

@SaiPradeepti

Desktop design screenshot for the REST Countries API with color theme switcher coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
4advanced
View challenge

Design comparison


SolutionDesign

Solution retrospective


Any suggestion on improving the code would be greatly appreciated.

Community feedback

Benjo Quilario• 1,810

@benjoquilario

Posted

Hi! Sai Pradeepti, you did a great job on finishing this one, it looks good and response rather well.

some suggestion to improve your code.

  • I think you need to add more route path for search only <Route path='/Search' element={<SearchResults />} /> because the page on your website contradict when searching and filtering, user can't filter the when the user still searching.
  • When searching in dark mode, dark color is only half on the screen viewport, you need add a min-height your your .app and put the background-color on class .app so that the whole viewport will have a dark color.

Overall you did well. Keep coding and happy coding too!

cheers, benjo

Marked as helpful

1

Sai Pradeepti• 130

@SaiPradeepti

Posted

Thanks for the advice Benjo Quilario

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord