Result Component Summary using HTML & CSS

Community feedback

• 

  Kamlesh Rajesh Yadav•5,040

  @Kamlesh0007

  Posted almost 2 years ago

  Congratulations on completing the challenge! That's a great achievement, and I'm sure you put a lot of effort into it. I really liked the way you approached the challenge and the code you wrote. You demonstrated a good understanding of the concepts and applied them effectively to solve the problem.I have a few suggestions to improve your code further. When it comes to centering a div or any element on a webpage, using margins may not always be the best approach. so use flexbox or grid layout for centering the div

  Here's an example code snippet:

  body {
  background-color: rgb(239, 235, 215);
  font-family: 'Hanken Grotesk', sans-serif;
  display: flex;
  flex-direction: column;
  justify-content: center;
  align-items: center;
  min-height: 100vh;
  }
  now remove below styles
  .container {
  margin-top: 80px;
  }
  

  and also You can add Semantic HTML tags to ur design The HTML structure should be semantically correct. The current structure doesn't provide any semantic information about the content. A better approach would be to use appropriate HTML tags such as <header>, <main>, <section>, <article>, etc. to define the sections of the page

  00

  Marked as helpful
• 

  P

  visualdennis•8,395

  @visualdenniss

  Posted almost 2 years ago

  Hey Michelle,

  congrats on completing the challenge successfully! Very neat job.

  Using width:50% on the container causes it to squeeze a lot when resizing the browser, while there is still enough space. Instead i'd suggest using width:100% but a max-width: some-value-in-rem. and add a small margin so it does not touch the edges of the screen.

  There seems to be some room for improving the design as well. The title "Your Result" should be something like white so it has enough contrast with the background. Also the background color of the page does not seem harmonious with the rest of the design, so i'd suggest keeping it cleaner by using something more neutral and closer to white.

  Hope you find this feedback helpful!

  10