Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 2 years ago

Result summary component

Crispy-Tofu•60
@Crispy-Tofu
A solution to the Results summary component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Feedback welcome:)

I had some problems getting the summaries on the left side of the component. I needed a lot of HTML markup to get it to work properly. And because I didn't fully plan it out, it has become a bit of a mess of classes.

  • When do people take a step back and decide to restructure the HTML markup?
  • How do people decide between adding classes to elements (making the p tag class="result__text" versus making the CSS selectors more specific (for example *.result p {} *)?
Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Julian•160
    @joewild90
    Posted over 2 years ago

    Hey! I know these problems too well. Especially when I do a project for learning I constantly try to optimize the html structure and css class names. Unfortunately in reality when you do work for clients you sometimes don't have enough time. So take your time when doing projects on frontend mentor. If I am done with a project I will look at other peoples solutions and adjust my code.

    To answer your second question you may want to read more about conventions/systems like BEM. You are already using the .block and .block__element notation in your code. According to my understanding when using BEM you make everything a class and avoid normal/nesting selectors. Therefor the question, when to nest selectors and when to use classes, does not arise. The hard part for me always is deciding when to start a new .block vs when to make it just another element.

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub