Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 1 year ago

Results Component with JSON Data

fetch
Kirsten ✨•460
@ofthewildfire
A solution to the Results summary component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


🎃 Results Summary Component with JSON data used 🎃

🤓 Questions

  • Is there any best practices with the way I have written / used the JSON data I am breaking?
  • I used <div> elements inside the <section> elements, and I did this because I thought, when the checks happen a section needs a heading, right? So, I am not putting on in those sub-sections (The <div> elements~) so, using a section is weird, so, I used a generic containing element. My question is, was this the right choice, or should I have used an article? That didn't make sense to me either, but, advice please. :)

👀 Known Issues

  • Currently this is failing the color contrast checks for the grey in the summary panels, I intend to fix that ...soon. 🥲
  • I am not happy with the width on the container (I used percentage) - I really don't know why I did, I cant remember, but, I don't like it, I do intend to change that as well.
  • Font types (the extension) I haven't converted them yet, I will do that in a hot minute.
  • The heading "Your result" on the purple panel, the color is a little hard to read as well, I had previously changed the color and updated the variable but never changed that heading color which is the reason. I will change it.

🫣 Posting despite the above listed issues because I have had this on my to-do list to post for 3 days now.... that is procrastination and I literally want to start the week on a better footing, LOL!!

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • P
    Dexter Dick•185
    @DexterDick
    Posted over 1 year ago

    Is there any best practices with the way I have written / used the JSON data I am breaking?

    add to js file import data from "../data.json" assert { type: "json" };

    add to html *

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit 1st-party linked stylesheets, and styles within <style> tags.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub