Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Results Summary Component

#accessibility

@11nena

Desktop design screenshot for the Results summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello, so this is my second component. It is not great but learned so much on it :) Thank you for any feedback it will help me to get better.

Community feedback

Shivraj K 400

@Shivraj-K09

Posted

  • Use more explanatory class names. Instead of using generic names like .showResult or .memory, try to use more descriptive and meaningful class names like .result-section or .memory-score.
  • Use semantic HTML tags. Semantically correct HTML structure makes the code easier to read, understand, and maintain. You can use tags like <header>, <section>, <article>, <nav>, <main>, etc.
  • Use consistent indentation and formatting style throughout the codebase. Consistency is key to improve code readability and maintainability.
  • Consider using BEM methodology to name your classes. BEM is a naming convention that makes it easier to understand the relationships and dependencies between different CSS classes.
  • Add more comments in the code, especially for complex or hard-to-understand sections. This will make it easier for other developers to understand the code and modify it if necessary.

Marked as helpful

0

@11nena

Posted

hello, thank you and good point :)

0
Taruna 305

@Tiyana19

Posted

hey, you did a great job, here are some suggestions attribution is sticking with the card so give it position: absolute and bottom: 0. and put the border: none value to the button.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord