@bilalturkmen
Posted
Hi, nice work. i think it can be improved a bit 😊
no need to use js to center an element.
✅css grid or flexbox is enough for this.
to center an element over the viewport area
you should add min-height
property to body selector like this
body{
min-height: 100vh;
display: grid;
font-family: "Hanken Grotesk", sans-serif;
text-align: center;
place-content: center;
}
and then you can delete the index.js. you dont need that anymore. you can also delete this div
- your media query breakpoint stays small for the width of the card design. should be expanded a little more like this
@media screen and (min-width: 768px) {
}
- and this div
✅ can be replaced as main
because document should have one main landmark.
- same this div
✅ can be replaced as h1
because page should contain a level-one heading
i hope these helpful 🙂
Marked as helpful
@myrojoylee
Posted
@bilalturkmen THANK YOU!!! it worked :D