Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 6 months ago

Results summary component main (data dynamically populated)

accessibility, sass/scss, bem
P
Denisse Joyce•290
@denissejoyce
A solution to the Results summary component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I did the bonus challenge which was to populate the data dynamically.

What specific areas of your project would you like help with?

For the sake of learning, I wanted to ask for help RE: using local font via font-face. I tried doing that for this challenge but it didn't work for me (code is left commented in typography partial).

Any feedback regarding my code is highly appreciated too!

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • P
    markus•2,740
    @markuslewin
    Posted 6 months ago

    Hi!

    Three changes:

    • The value of font-family of body has to match the font-family of the @font-face, i.e. either HankenGrotesk in both places, or Hanken Grotesk in both places.
    • font-weight: bolder sets the weight of an element relative to the parent element, so I don't think it makes sense to use bolder in the context of specifying a font face. I think it's better to map it to a numerical value, like 800.
    • The urls are written to point to the font files relative to main.scss, but they need to be written relative to the outputted main.css that index.html links to. url(../assets/fonts/static/HankenGrotesk-Medium.ttf) (relative to main.css) or url(/assets/fonts/static/HankenGrotesk-Medium.ttf) (relative to root) should work better!
    @font-face {
      font-family: "Hanken Grotesk";
      src: url(../assets/fonts/static/HankenGrotesk-Medium.ttf) format("truetype");
      font-weight: normal;
      font-style: normal;
    }
    
    body {
      font-family: "Hanken Grotesk", serif;
    }
    
    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub