Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Request failed with status code 502
Request failed with status code 502
Request failed with status code 502

Submitted

Results summary component

good-mistakeโ€ข 240

@good-mistake

Desktop design screenshot for the Results summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hi, this is my solution for this challenge. If you have any ideas on what I can improve , please let me know. Your feedback is welcome. Thank you

Community feedback

Daniel ๐Ÿ›ธโ€ข 36,160

@danielmrz-dev

Posted

Hello @good-mistake!

Your solution looks great!

I have a couple of suggestions for improvement:

  • First: In order to make your HTML code more semantic, don't skip heading levels - start with <h1>, then use <h2>, and so on.. Unlike what most people think, it's not just about the size and weight of the text.

๐Ÿ“Œ The <h1> to <h6> tags are used to define HTML headings.

๐Ÿ“Œ <h1> defines the most important heading.

๐Ÿ“Œ <h6> defines the least important heading.

๐Ÿ“Œ Only use one <h1> per page - this should represent the main heading/title for the whole page.

  • Second: Still about semantic HTML, use <main> to wrap the main content instead of <div>.

All these tag changes may have little or no visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.

I hope it helps!

Other than that, great job!

Marked as helpful

1

good-mistakeโ€ข 240

@good-mistake

Posted

Thank you @danielmrz-dev for your suggestions, I was a little confused about the headings in this challenge, and I'll try to improve my SEO in my future challenges. Thanks again for the feedback.

1

@MelvinAguilar

Posted

Hello there ๐Ÿ‘‹. Good job on completing the challenge !

I have some suggestions about your code that might interest you.

  • Even though the number '76' is the largest text in the component, it doesn't necessarily mean it should be an <h1>. Headings have a hierarchy and are meant to indicate the structure and importance of content .In your solution, one of the important header elements is a number that does not describe the component itself.
  • Use semantic elements such as <main> and <footer> to improve accessibility and organization of your page.
  • If the image is purely decorative, meaning it's an icon that doesn't add any essential information to the page, you can leave its alt attribute empty so that screen readers can ignore the image.

  • To center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here ๐Ÿ“˜.

I hope you find it useful! ๐Ÿ˜„ Above all, the solution you submitted is great!

Happy coding!

Marked as helpful

1

good-mistakeโ€ข 240

@good-mistake

Posted

Thank you @MelvinAguilar for your suggestions , I was confused about the headers in this challenge so I thought the number "76" might be one. Thanks again for the feedback and the link about centering in CSS , I read it and it was helpful and I try to use it in my future challenges.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord