Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 2 years ago

Results summary component

HeroLeam•30
@HeroLeam
A solution to the Results summary component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


In my view it was a simple project to start my career, I had no difficulties, the project is visibly close to the challenge, I can't say if I did the development correctly and not to say the patterns in question of typing the codes.

If you can evaluate and mention points that I can improve, thank you!

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Abdul Khaliq 🚀•72,380
    @0xabdulkhaliq
    Posted about 2 years ago

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • I have other recommendations regarding your code that I believe will be of great interest to you.

    DECORATIVE SVG'S ♨️:

    • The alt attribute is used to provide alternative text for images in HTML documents. The alt attribute is used by screen readers to describe the image to visually impaired users, which is essential for web accessibility.

    • Now, when it comes to decorative SVGs, they are used purely for aesthetic purposes and do not convey any important information or functionality to the user.

    • Since these images do not convey any important information or functionality, there is no need for an alt attribute.

    • So feel free to set the alt attribute as "" for decorative svg's, because alt="" will be skipped by screen readers they will consider the image as decoration

    Example:

    <img src="images/decorative.svg" alt="">
    
    
    <img class="reaction-image" src="./images/icon-reaction.svg" alt="icon-reaction">
    👇
    <img class="reaction-image" src="./images/icon-reaction.svg" alt="">
    
    

    .

    I hope you find this helpful 😄 Above all, the solution you submitted is great !

    Happy coding!

  • ThanHtike(テンタイ)•110
    @CGM-ThanHtike
    Posted about 2 years ago

    Dear @heroleam, I had reviewed you code and found out some points that can be improved.

    • you style.css should be written at the lowest level in <head> tag because it might be overwrite by other other css classes, if u use bootstrap or other frameworks in the future.

    • form-circle-text-secundary, you should aware of your spellings (it might hurts sometimes)

    • Shouldn't use spam for everything, ex: <span class="form-summary-text">Summary</span> you can use h1 element here and <p> tag for paragraph.

    • You are declaring some unnecessary css properties like flex-direction: row; as the default flex-direction is row, u don't need to declare anything.

    I think the [youtube video] will help. (https://www.youtube.com/watch?v=rxnX1jdoI6c&t=65s)

    • You wrote all css again in style-mobile.css. I'm not sure about landscape and portrait, however, if u use like @media(max-width: 768px), all the css you are declaring are effected also for mobile screens and all you need to do is modify some styles for mobile in media query.

    Overall, You did a great job in making it almost same as the design. I'm also still learning to improve my skills and hope my review will help you to improve in some ways. Best Regards!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub